Skip to content

fix(viewer): guard texture.repeat against non-array values (Sentry MONOREPO-EDITOR-EK) #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aymericr merged 2 commits into from
Jul 19, 2026
+53 −6
Merged

fix(viewer): guard texture.repeat against non-array values (Sentry MONOREPO-EDITOR-EK) #504

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac68186
fix(viewer): guard texture.repeat against non-array values (Sentry MO…
Jul 17, 2026
c40517d
fix(viewer): normalize legacy texture repeats
Aymericr Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/viewer/src/lib/materials.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,9 @@ function getCacheKey(props: MaterialProperties, shading: RenderShading): string
function getTextureKey(material?: MaterialSchema): string {
const texture = material?.texture
if (!texture) return 'none'
const repeat = texture.repeat?.join('x') ?? 'default'
const repeat = Array.isArray(texture.repeat)
? texture.repeat.join('x')
: (texture.repeat ?? 'default')
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated
const scale = texture.scale ?? 'default'
return `${texture.url}-${repeat}-${scale}`
}
Expand Down
Loading