-
-
Notifications
You must be signed in to change notification settings - Fork 162
fix: remove associated filters during stream deletion #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spuckhafte
wants to merge
13
commits into
parseablehq:main
Choose a base branch
from
spuckhafte:orphan_filters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
aca2671
fix: remove associated filters during stream deletion
spuckhafte 19704d9
chore: safe await
spuckhafte d812994
chore: refactor logic for deleting zombie filters
spuckhafte 6e96d09
chore: simplification
spuckhafte ffd81aa
chore: refactored zombie filter deletion into a general utlity func
spuckhafte fbc3b52
chore: cleanup, simplification
spuckhafte 332485d
chore: generalized filter cleanup response and error
spuckhafte 82dae76
fix: zombie filters cleanup also includes sql filters now
spuckhafte 5295f70
fix: also incorporated FilterType::Search type
spuckhafte 8f50052
fix: optimized regex
spuckhafte 8147ad4
fix: delete_zombie_filters in query server
spuckhafte 1a3564a
chore: log the error from delete_zombie_filters
spuckhafte 373e9df
chore: same (as last commit) for query server
spuckhafte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.