Update trie-db version to 0.28.0#1522
Merged
Merged
Conversation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
lexnv
added
A1-insubstantial
lexnv
commented
Sep 12, 2023
| // that the value doesn't exist in the trie. | ||
| self.update_recorded_keys(full_key, RecordedForKey::Value); | ||
| }, | ||
| TrieAccess::InlineValue { full_key } => { |
Contributor
Author
There was a problem hiding this comment.
@bkchr Would like to double check this with you 🙏
(introduced by: paritytech/trie#194)
cheme
reviewed
Sep 12, 2023
| @@ -379,6 +379,19 @@ impl<H: Hasher, I: DerefMut<Target = RecorderInner<H::Out>>> trie_db::TrieRecord | |||
| // that the value doesn't exist in the trie. | |||
| self.update_recorded_keys(full_key, RecordedForKey::Value); | |||
Contributor
There was a problem hiding this comment.
this should switch to RecordedForKey::None I think
Member
There was a problem hiding this comment.
No the current value is correct. The comment also says why we pass there Value.
Contributor
There was a problem hiding this comment.
I don't understand it (this did make sense to me).
Member
There was a problem hiding this comment.
Good find 🙈
See this docs: https://github.com/paritytech/trie/blob/692ee41a6bd0df36252663d2f7974ab1c368d9a0/trie-db/src/lib.rs#L193-L220
Maybe I should have given None a different name, but the docs are explaining it.
bkchr
approved these changes
Sep 13, 2023
| @@ -379,6 +379,19 @@ impl<H: Hasher, I: DerefMut<Target = RecorderInner<H::Out>>> trie_db::TrieRecord | |||
| // that the value doesn't exist in the trie. | |||
| self.update_recorded_keys(full_key, RecordedForKey::Value); | |||
Member
There was a problem hiding this comment.
No the current value is correct. The comment also says why we pass there Value.
Co-authored-by: Bastian Köcher <git@kchr.de>
cheme
approved these changes
Sep 13, 2023
serban300
approved these changes
Sep 13, 2023
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
This PR updates: - trie-db from 0.27.1 to 0.28.0 - trie-bench from 0.37.0 to 0.38.0 (deb-dependency) While at it, also adapts the recorder to take into account the newly added `TrieAccess::InlineValue`. Needed by: - paritytech#1153 @paritytech/subxt-team --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: Bastian Köcher <git@kchr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates:
While at it, also adapts the recorder to take into account the newly added
TrieAccess::InlineValue.Needed by:
@paritytech/subxt-team