Conversation
niklasad1
commented
Apr 23, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
A release pull request updating the project with version v0.25.0, including breaking changes in the RpcServiceT trait to support both client- and server-side operations and multiple dependency bumps.
- Bumps version numbers in Cargo.toml and updates internal dependencies.
- Updates CHANGELOG.md to document new features, fixes, and breaking changes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Updated version and dependency versions to v0.25.0 |
| CHANGELOG.md | Added detailed release notes including new features and fixes |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jsdw
reviewed
Apr 24, 2025
|
Merge and release quickly |
Co-authored-by: James Wilson <james@jsdw.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for this change is to make it work for the client-side as well as make it easier to
with return
impl Futureinstead require an associated type for theFuturewhich in many casesrequires BoxFuture or ResponseFuture which improves ergonomics.
The downside of this change is that one has to duplicate the logic in the
batchandcallmethod to achieve the samefunctionality as before. Thus,
callornotificationis not being invoked in thebatchmethod and one has to implementdoes separately.
For example now it's possible to write middleware that counts the number of method calls as follows (both client and server):
In addition because this middleware is quite powerful it's possible to
modify requests and specifically the request ID which should be avoided
because it may break the response verification especially for the client-side.
See #1565 for further information.
There are also a couple of other changes see the detailed changelog below.
[Added]
request timeoutgetter (#1533)ServerConfigBuilder::build(#1484)[Fixed]
http request bodylog (#1540)[Changed]
Box<RawValue>(#1545)ServerConfigBuilder/ServerConfigreplacesServerBuilderduplicate setter methods (#1487)ProxyGetRequestLayerhttp middleware support multiple path-method pairs (#1492)