Skip to content

re-enable test_pantsd_memory_usage #23292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cburroughs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

re-enable test_pantsd_memory_usage #23292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/python/pants/pantsd/pantsd_integration_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,8 +445,6 @@ def test_pantsd_pid_change(self):
# Remove the pidfile so that the teardown script doesn't try to kill process 9.
os.unlink(pidpath)

@pytest.mark.skip(reason="flaky: https://github.com/pantsbuild/pants/issues/8193")
@pytest.mark.no_error_if_skipped
def test_pantsd_memory_usage(self):
"""Validates that after N runs, memory usage has increased by no more than X percent."""
number_of_runs = 10
Expand All @@ -462,11 +460,9 @@ def test_pantsd_memory_usage(self):
ctx.checker.assert_running()

final_memory_usage = ctx.checker.current_memory_usage()
self.assertTrue(
initial_memory_usage <= final_memory_usage,
f"Memory usage inverted unexpectedly: {initial_memory_usage} > {final_memory_usage}",
assert initial_memory_usage > 0, (
f"Expected non-zero initial memory usage, got {initial_memory_usage}"
)

increase_fraction = (float(final_memory_usage) / initial_memory_usage) - 1.0
self.assertTrue(
increase_fraction <= max_memory_increase_fraction,
Expand Down
Loading