Feature: Add generic option to docker image#23250
Conversation
tim-werner
force-pushed
the
add-generic-option-to-docker-image
branch
from
124c44c to
99f5e5d
Compare
There was a problem hiding this comment.
Hi! Thanks for the contribution!
The feature looks well thought out w.r.t how options should be propagated, and I agree with the general direction of providing a list of args instead of adding a new option for each arg.
I am however not going to review the test cases before you do. Happy to once they at least conform to the style of the test file where they were introduced.
|
Hi @tobni , |
sureshjoshi
left a comment
sureshjoshi
left a comment
There was a problem hiding this comment.
Thanks for the contribution. We've just branched for 2.32.x, so merging this pull request now will come out in 2.33.x, please move the release notes updates to docs/notes/2.33.x.md if that's appropriate.
There was a problem hiding this comment.
Thanks! Tests and cleanup looks good.
I am a bit on the fence about whether it is actually desirable for the subsystem level extra-list to override the dedicated fields. To clarify, I still think the churn associated with maintaining the fields is real, and not parsing them as invidual fields like pants is currently doing would be better UX.
However, as the system currently looks and works, a release note callout isn't enough I dont think.
Either per target field options override global options, or a warning has to be emitted that we are ignoring target field options and hint at the correct way to override (setting the new per target extras field) is mandatory for this to land.
| #### Docker | ||
|
|
||
| The option `[docker].build_extra_options` or/and the `build_extra_options` field of `docker_image` targets can now be used to pass extra options to docker build or podman build. Make sure that the options are understood by the tool. | ||
| For example, you can now set `build_extra_options=["--no-cache"]` to do not use existing cached images for the container build. |
There was a problem hiding this comment.
Sorry that was vague. The example sentence is not parsable for me.
There was a problem hiding this comment.
I have updated the documentation
There was a problem hiding this comment.
There are now warnings when fields are overwritten.
|
@tobni thank you very much for the review. I have added warnings and updated the documentation. I think it is fine that the subsystem level extra-list overrides the dedicated fields with the additional warnings. This will make it much easier to deprecated the dedicated fields in future. |
|
@tobni @sureshjoshi it seems that the test was killed by the runner probably because of timeout or memory .... |
3 participants
This pull request allows it now to add generic build options to docker/podman build. It will also work as a workaround for issue: #21450
It is now possible to use pass generic build options to docker and podman. The old arguments such as pull on docker_image target level or no-cache on global level will still work, however the new build_extra_option will have precedence.
AI was used to find the right locations in the code base for the changes and to write the tests faster. However, most of the code was written by human.
This is an improvement of pull request: #23032