BUG: Fixes #62775 - DataFrame.from_dict() drops empty rows with orient='index'#65615
BUG: Fixes #62775 - DataFrame.from_dict() drops empty rows with orient='index'#65615J281417 wants to merge 6 commits into
Conversation
|
Hi my name is Nol, I'd like to contribute to this issue. Currently, the iteration skips s.values() when its blank. So i've added an explicit assign np.nan. Also, ive added a list of cols so that a row that has no values will be populated with np.nan and maintains expected column sequence. Please review and provide feedback. Thank you |
|
@J281417 looks like there are a couple failing tests. |
|
Hi @mapanahi, |
No. You don't need to assign to anybody. The reviewers periodically look for open PRs. |
|
Thanks @mapanahi, Goit it working. Just have to wait for reviewer now. |
rhshadrach
left a comment
There was a problem hiding this comment.
Thanks for the PR but I'm negative on this approach; can you instead do
index = list(data.keys())
where this is called from. That already then flows through to DataFrame construction.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.