Skip to content

fix(log-detective): do not log missing run as error #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfocko merged 1 commit into from
May 28, 2026
+1 −1
Merged

fix(log-detective): do not log missing run as error #3136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packit_service/worker/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1922,7 +1922,7 @@ def parse_logdetective_analysis_event(event) -> Optional[logdetective.Result]:
analysis_id=analysis_id
)
if not log_detective_run:
logger.error(
logger.info(
f"Received results Log Detective analysis: '{analysis_id}' "
"but no analysis with this id was requested."
)
Comment on lines +1925 to 1928
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the Repository Style Guide (lines 537-539), when a parser returns None because the event doesn't satisfy specific conditions, a warning must be logged. Changing this log level to info violates this guideline. Please use logger.warning instead.

Suggested change
logger.info(
f"Received results Log Detective analysis: '{analysis_id}' "
"but no analysis with this id was requested."
)
logger.warning(
f"Received results Log Detective analysis: '{analysis_id}' "
"but no analysis with this id was requested."
)
References
  1. Parsers process dictionaries and must either return a parsed object, or None, if the dictionary doesn't satisfy conditions specific to the event. In cases when parser returns None, a warning must be logged. (link)

Copy link
Copy Markdown
Member Author

@mfocko mfocko May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not true for this parser even before I adjusted this one instance…

Expand Down
Loading