Switch to using testing-farm multihost pipeline#3127
Conversation
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds multihost support for Testing Farm by introducing a multihost parameter to the _get_tf_base_payload method, which configures the pipeline type as tmt-multihost. Several payload generation methods were updated to enable this flag. The reviewer requested an update to the _get_tf_base_payload docstring to include the new parameter and comply with the Google-style documentation requirements specified in the repository's style guide.
| def _get_tf_base_payload( | ||
| self, | ||
| distro: str, | ||
| compose: Optional[str], | ||
| multihost: bool = False, | ||
| ) -> dict: |
There was a problem hiding this comment.
The docstring for _get_tf_base_payload should be updated to include the new multihost parameter and follow the Google-style format as required by the repository style guide (lines 412-414). It is currently missing the Args and Returns sections, which are necessary for non-trivial methods like this one that construct complex payload structures.
References
- All code must contain accurate and sufficiently detailed docstrings, formatted in accordance with the PEP 257 standard and in Google-style (including Args and Returns sections). (link)
|
Why do you want to turn it on by default? 👀 |
|
✔️ pre-commit SUCCESS in 2m 10s |
Because if It is a draft until can confirm that it is stable for those simple tests, will post an example run when I have it |
|
Yep, I've identified 2 bugs with multihost pipeline affecting these, so definitely not ready yet:
|
2 participants
TODO: