Add crypto extern to behavioral-model #834
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| crypto_SOURCES = crypto.cpp | ||
| crypto_LDADD = -lcrypto | ||
|
|
||
| CPPFLAGS += -I../../ -fPIC -shared | ||
|
|
||
| libexterncrypto.so : $(crypto_SOURCES) | ||
| g++ $(CPPFLAGS) $(crypto_SOURCES) -o libexterncrypto.so $(crypto_LDADD) | ||
|
|
||
| clean: | ||
| rm -rf libexterncrypto.so | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,25 @@ | ||||||
| # ADD CRYPTO EXTERN to SIMPLE_SWITCH | ||||||
|
Member
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| For reference, the extern is implemented in crypto.cpp in this directory. | ||||||
| This cpp code is to be incorporated in | ||||||
| behavioral-model/targets/simple_switch/simple_switch.cpp | ||||||
|
Member
There was a problem hiding this comment. That's not accurate. You should instead include the following instructions:
Please also make sure that these instructions work properly.
Contributor
Author
There was a problem hiding this comment. I don't see a |
||||||
|
|
||||||
| The code is crypto.cpp is also available in the repo URL included below | ||||||
| so that testing can be done using MACsec (MAC security) code. A | ||||||
| README.md is available at the repo below with steps for how to test | ||||||
| the code. | ||||||
|
|
||||||
| https://github.com/uni-tue-kn/p4-macsec | ||||||
|
|
||||||
| The extern is defined in the following P4 file. Search for ExternCrypt | ||||||
|
Member
There was a problem hiding this comment. I recommend copy-pasting the P4 extern type definition here since it's only a few lines, in case the link becomes broken in the future. |
||||||
| for the extern definition. Additionally the extern is used in P4 code | ||||||
| as crypt.validate() which is decryption and crypt.protect() which is | ||||||
| encryption. | ||||||
|
|
||||||
| https://github.com/uni-tue-kn/p4-macsec/p4/p4/basic.p4 | ||||||
|
|
||||||
| basic.p4 is used to test the cryto extern code with simple_switch. | ||||||
|
|
||||||
| basic.p4 is compiled using p4c with args shown in | ||||||
|
Member
There was a problem hiding this comment. again, please provide the command-line as part of this README, I think it's valuable. |
||||||
|
|
||||||
| https://github.com/uni-tue-kn/p4-macsec/blob/master/p4/p4/Makefile | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this extern is a bit complicated, I think we should have a simple C++ test and a
make checktarget in this Makefile to make sure that the extern definition is not broken and that encryption / decryption work properly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me think about this one and get back.