Fix entry addition logic for keyless match tables#1339
Open
Shivampal157 wants to merge 1 commit intop4lang:mainfrom
Open
Fix entry addition logic for keyless match tables#1339Shivampal157 wants to merge 1 commit intop4lang:mainfrom
Shivampal157 wants to merge 1 commit intop4lang:mainfrom
Conversation
Signed-off-by: Shivampal157 <shivampal60076@gmail.com>
Contributor
|
I do not understand why you believe it should be possible to add an entry to a P4 table with no key fields. If you never add an entry to such a table, it should always get a miss on any table_name.apply() call, and execute the table's default_action. This is what happens today, yes? Said another way: suppose it was possible to add an entry to such a keyless table. Should future calls to table_name.apply() then get a hit, instead of a miss? Why? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes entry addition logic for keyless match tables.
Previously, adding an entry to a table with no match key (get_size_key() == 0)
would always fail with NO_TABLE_KEY, even when the provided match_key was empty.
What changed
Files changed
Motivation
This restores correct behavior for keyless tables such as get_lb_key,
which rely on a default action without match keys.