Repository navigation
Conversation
libqc's `importWallet` persists an empty address list, so a recovered wallet only gets its index-0 vault back from the missing-default-chain branch. Every later vault (each `emptyVault` rotation mints the next index) had to be re-derived by the boot safety net, which minted exactly one index per `initWallet` and only re-checked on the next popup boot. A user who had rotated three times therefore saw an empty wallet right after recovery and needed several open/close cycles before the vault holding their funds showed up. Chain the safety-net repair: after minting an index, inspect the minted vault's status and keep advancing while it reports `vulnerable`, so the whole history is rediscovered during the recovery hydration. A fresh, never-used derivation reports `safe` and terminates the chain, so the non-recovery case is unchanged (one mint). A per-chain cap guards against a status provider that never reports `safe`.
kriss39
requested review from
antoni0dev,
conor-deegan,
crosby and
ralphking
as code owners
September 13, 2026 12:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libqc's
importWalletpersists an empty address list, so a recovered wallet only gets its index-0 vault back from the missing-default-chain branch. Every later vault (eachemptyVaultrotation mints the next index) had to be re-derived by the boot safety net, which minted exactly one index perinitWalletand only re-checked on the next popup boot. A user who had rotated three times therefore saw an empty wallet right after recovery and needed several open/close cycles before the vault holding their funds showed up.Chain the safety-net repair: after minting an index, inspect the minted vault's status and keep advancing while it reports
vulnerable, so the whole history is rediscovered during the recovery hydration. A fresh, never-used derivation reportssafeand terminates the chain, so the non-recovery case is unchanged (one mint). A per-chain cap guards against a status provider that never reportssafe.Why
How
Security / Environment Variables (if applicable)
Testing