Repository navigation
Conversation
…inted `resolveReplacementVaultAction` deliberately skips minting a replacement vault when the destination is an owned account, when another same-chain vault is already `safe`, or when a sibling's status is unknown. The post-withdraw reconcile loop, however, only treated the owned-destination case as terminal: in the other two skip branches (and on auto-resumed reconciles after a reboot, where any replacement already sits in the baseline) `isPostWithdrawComplete` waited for a fresh account outside the baseline that can never appear, polled the SDK for the full 30s window and then surfaced a "Sync delayed" banner for a withdrawal that had succeeded. Thread `expectsReplacementAccount` from the withdraw path (true only when a replacement was actually created) and the resume effect (always false) into the loop, and settle on the source-side signal alone when no replacement is expected.
kriss39
requested review from
antoni0dev,
conor-deegan,
crosby and
ralphking
as code owners
September 13, 2026 12:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…inted
resolveReplacementVaultActiondeliberately skips minting a replacement vault when the destination is an owned account, when another same-chain vault is alreadysafe, or when a sibling's status is unknown. The post-withdraw reconcile loop, however, only treated the owned-destination case as terminal: in the other two skip branches (and on auto-resumed reconciles after a reboot, where any replacement already sits in the baseline)isPostWithdrawCompletewaited for a fresh account outside the baseline that can never appear, polled the SDK for the full 30s window and then surfaced a "Sync delayed" banner for a withdrawal that had succeeded.Thread
expectsReplacementAccountfrom the withdraw path (true only when a replacement was actually created) and the resume effect (always false) into the loop, and settle on the source-side signal alone when no replacement is expected.Why
How
Security / Environment Variables (if applicable)
Testing