Repository navigation
Conversation
This PR patches a HIGH severity session security vulnerability in the wallet frontend. Key Changes: Idle Lock Enforced: Changed the tracking policy for the signing-sensitive vault-withdraw screen from never to when-unlocked. This ensures that the wallet will correctly lock if the user is inactive during the withdrawal review and submission process. Regression Testing: Added a test in use-session-timeout.test.ts to prove that withdrawal inactivity is explicitly tracked while the vault is unlocked, and untracked once locked.
magqqgq
requested review from
antoni0dev,
conor-deegan,
crosby and
ralphking
as code owners
August 16, 2026 21:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR patches a HIGH severity session security vulnerability in the wallet frontend.
Key Changes:
Idle Lock Enforced: Changed the tracking policy for the signing-sensitive vault-withdraw screen from never to when-unlocked. This ensures that the wallet will correctly lock if the user is inactive during the withdrawal review and submission process.
Regression Testing: Added a test in use-session-timeout.test.ts to prove that withdrawal inactivity is explicitly tracked while the vault is unlocked, and untracked once locked.