Background task: delete expired tokens#10440
Draft
david-crespo wants to merge 1 commit into
Draft
Conversation
david-crespo
commented
May 13, 2026
| WHERE time_expires IS NOT NULL AND time_expires < $1 \ | ||
| ORDER BY time_expires \ | ||
| LIMIT $2", | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Same as https://github.com/oxidecomputer/omicron/pull/10009/changes#r2908069585: the query DSL can't do order by and limit on a delete.
just-be-dev
reviewed
May 25, 2026
| /// This must be updated when you change the database schema. Refer to | ||
| /// schema/crdb/README.adoc in the root of this repository for details. | ||
| pub const SCHEMA_VERSION: Version = Version::new(257, 0, 0); | ||
| pub const SCHEMA_VERSION: Version = Version::new(258, 0, 0); |
Contributor
There was a problem hiding this comment.
Dang lol. Y'all have been busy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude one-shot based on #10009, which did the same for expired sessions. Closes #8282.