Draft
Conversation
0b1af44 to
6b3f76f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two ereport flavors for Cosmo sequencer issues:
hw.seq.regsis a raw dump of the registers, along with a reason why it was produced (MAPO, timeout, or "suddenly we're not in A0")hw.seq.timeout.*is a family of ereports representing timeouts at each stage of sequencing, along with a diagnosis. It includes anOption<u64>that refers to ahw.seq.regsENA, so that we can also look at raw register values (if the diagnosis is not helpful).For failure modes other than timeout, this PR doesn't send any additional ereports (just the
hw.seq.regsvalue).Consider this a starting point for brainstorming how we want to organize this data (e.g. one alternative is sending the high-level ereport first, then have the
hw.seq.regsrefer to it).