Sync bun-vscode packageManager schema with SchemaStore#29520
Open
LitoMore wants to merge 1 commit intooven-sh:mainfrom
Open
Sync bun-vscode packageManager schema with SchemaStore#29520LitoMore wants to merge 1 commit intooven-sh:mainfrom
LitoMore wants to merge 1 commit intooven-sh:mainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughModified the JSON schema validation pattern for the Changes
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I've changed the pattern for
package.json'spackageManagerfield to make Bun's version optional.Bun is the runtime; forcing version here is not a good choice. And Corepack does not support Bun, so whether or not there is a version of Bun doesn't really matter for Corepack users.
How did you verify your code works?
The SchemaStore already applied the new schema, and it works. See:
packageManagerSchemaStore/schemastore#5589