Skip to content

Sync bun-vscode packageManager schema with SchemaStore#29520

Open
LitoMore wants to merge 1 commit intooven-sh:mainfrom
LitoMore:update-package-json-schema
Open

Sync bun-vscode packageManager schema with SchemaStore#29520
LitoMore wants to merge 1 commit intooven-sh:mainfrom
LitoMore:update-package-json-schema

Conversation

@LitoMore
Copy link
Copy Markdown

What does this PR do?

I've changed the pattern for package.json's packageManager field to make Bun's version optional.

Bun is the runtime; forcing version here is not a good choice. And Corepack does not support Bun, so whether or not there is a version of Bun doesn't really matter for Corepack users.

How did you verify your code works?

The SchemaStore already applied the new schema, and it works. See:

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b15f3b8e-0d1e-421d-a83b-7a98429511ee

📥 Commits

Reviewing files that changed from the base of the PR and between 0e2d207 and 3b75399.

📒 Files selected for processing (1)
  • packages/bun-vscode/assets/package.json

Walkthrough

Modified the JSON schema validation pattern for the packageManager field to allow either specific package manager versions (npm|pnpm|yarn|bun@<semver>) or plain "bun" without version specification.

Changes

Cohort / File(s) Summary
JSON Schema Update
packages/bun-vscode/assets/package.json
Updated packageManager pattern from (bun|npm|pnpm|yarn)@\d+\.\d+\.\d+(-.+)? to ^((npm|pnpm|yarn|bun)@\d+\.\d+\.\d+(-.+)?|bun)$ to support versioned package managers or plain "bun".
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Sync bun-vscode packageManager schema with SchemaStore' clearly and concisely describes the main change: updating the packageManager schema to align with SchemaStore.
Description check ✅ Passed The PR description covers both required template sections: it explains what the change does (making Bun's version optional) and how it was verified (tested in SchemaStore).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant