fix: use _len instead of _length in Array.decode range()#337
Open
AmSach wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the bug described in issue #336.
The decode method for CIP Array types was using _length instead of _len in the range() call, which resulted in the error: TypeError: _DataTypeMeta object cannot be interpreted as an integer when decoding array types like Array(UINT, ActiveLanguage).
Root cause: Line 872 used _length (which can be a DataType meta object) instead of _len (the decoded integer value) when iterating over array elements.
Fix: Changed range(_length) to range(_len).
Fixes #336