added templates (draft) - #13
Open
BatiGencho wants to merge 1 commit into
Open
Conversation
gnmerritt
reviewed
Nov 19, 2021
gnmerritt
left a comment
gnmerritt
left a comment
Contributor
There was a problem hiding this comment.
seems good to me so far. what happens if you pass both a template and a body to the send API - terrible things?
happy to merge this when you're happy with it and sorry for the long delay in getting back to you
| pub description: String, | ||
| pub template: Option<String>, | ||
| pub tag: Option<String>, | ||
| pub engine: Option<String>, |
Contributor
There was a problem hiding this comment.
could we make this a single-value enum so that it's only possible to pass in handlebars for now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.