fix(tsa): restreint vraiment le CORS à l'origine configurée - #8
Merged
Merged
Conversation
allow_origin(HeaderValue) (AllowOrigin::exact) renvoyait Access-Control-Allow-Origin: <origine configurée> sur TOUTE requête, quelle que soit l'origine réelle de l'appelant — pas une exploitation directe (le navigateur compare toujours l'en-tête à sa propre origine avant d'autoriser la lecture), mais une fuite de configuration et pas la vraie restriction par origine documentée. AllowOrigin::list ne reflète l'en-tête que si l'Origin de la requête correspond exactement, et l'omet sinon. Ajoute le test qui aurait dû l'attraper.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scoped change and regression coverage address the intended CORS behavior.
Pull request overview
Restricts TSA CORS responses to configured origins and adds regression coverage.
Changes:
- Applies exact request-origin matching.
- Tests that unauthorized origins receive no CORS header.
File summaries
| File | Description |
|---|---|
crates/oe-httpapi/tests/end_to_end.rs |
Adds unauthorized-origin CORS coverage. |
crates/oe-httpapi/src/lib.rs |
Applies origin-aware CORS filtering. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Résumé
allow_origin(HeaderValue)(=AllowOrigin::exact) renvoyaitAccess-Control-Allow-Origin: <origine configurée>sur toute requête, quelle que soit l'origine réelle de l'appelant — pas une faille directement exploitable (le navigateur compare toujours l'en-tête à sa propre origine), mais pas la restriction par origine documentée non plus.AllowOrigin::listne reflète l'en-tête que si l'Originde la requête correspond exactement, et l'omet sinon.Trouvé en vérifiant manuellement le CORS déployé sur le staging avec une origine non autorisée.
Plan de test