Repository navigation
fix(images): applique les correctifs de sécurité Debian au build - #2
Merged
Merged
Conversation
Le job Trivy de la CI échouait sur libpcre2-8-0 (CVE-2026-86145, CVE-2026-89161, dépendance transitive d'opensc/grep) : apt-get update seul n'entraîne pas la mise à niveau des paquets déjà présents dans l'image de base, et le cache GHA de cette couche la rejoue telle quelle d'un build à l'autre. Ajoute apt-get upgrade -y avant l'installation, dans les 3 Dockerfiles (ca-server, tsa, ocsp-responder).
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The cacheable APT layer may preserve vulnerable packages; explicit cache invalidation or bypass is needed.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the three Debian runtime images to apply security upgrades addressing Trivy findings.
Changes:
- Adds
apt-get upgrade -ybefore package installation. - Applies the change to CA, TSA, and OCSP images.
File summaries
| File | Summary |
|---|---|
deploy/tsa/Dockerfile |
Upgrades Debian packages during image construction. |
deploy/ocsp-responder/Dockerfile |
Upgrades Debian packages during image construction. |
deploy/ca-server/Dockerfile |
Upgrades Debian packages during image construction. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Suite à la revue Copilot sur #2 : cache-from/cache-to: type=gha rejouait sinon indéfiniment la couche apt-get update/upgrade, gelant les paquets Debian installés à leur version du premier build en cache — la cause racine derrière libpcre2-8-0 resté vulnérable malgré apt-get update. Ajoute un ARG CACHEBUST (date du jour, calculée par la CI) dans les 3 Dockerfiles, propagé sur tous les builds de ces images (build, publish, helm-kind-smoke-test).
Contributor
Author
|
Ajout d'un cache-bust journalier (CACHEBUST) suite à la remarque Copilot : le cache GHA de la couche apt-get rejouait indéfiniment le même |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Résumé
libpcre2-8-0(CVE-2026-86145, CVE-2026-89161) dans les 3 images (ca-server, tsa, ocsp-responder).apt-get upgrade -yavant l'installation des paquets, dans les 3 Dockerfiles, pour que le build applique les derniers correctifs de sécurité Debian même quand la coucheapt-get updateest servie depuis le cache GHA.Plan de test