fix: add optional exp claim to back-channel logout token#4073
Conversation
|
Hi Hydra team ( @aeneasr ), There's two CI failures, but I’d appreciate it if you could take a look at this PR when you get a chance. Thanks! |
cff6a79 to
76913b0
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
✅ Files skipped from review due to trivial changes (4)
📝 WalkthroughWalkthroughAdds an optional ChangesLogout Token Expiration
Non-functional import/formatting edits
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@spec/config.json`:
- Around line 731-733: The description for the logout token duration refers to
setting the value to numeric "0" but the schema is a duration string; update the
wording to require the zero duration to be expressed as "0s" (or another valid
duration string) and clarify that a plain numeric 0 is invalid. Locate the
description string in spec/config.json (the logout token duration field) and
change "set to 0" to "set to \"0s\" (zero seconds) or left unset" and mention it
must follow the duration string format defined by the schema.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c9ede95e-17e3-447a-9dd3-741ae4856633
📒 Files selected for processing (4)
consent/strategy_default.goconsent/strategy_logout_test.godriver/config/provider.gospec/config.json
4b1d68b to
8875bf2
Compare
8875bf2 to
c5cd96a
Compare
The OpenID Connect Back-Channel Logout 1.0 specification requires the
expclaim in logout tokens, but Hydra currently omits it.This adds a new
ttl.logout_tokenconfiguration option. When set (e.g.2m), theexpclaim is included in the logout token.When unset or 0, the current behavior is preserved for backward compatibility.
Related issue(s)
#4035
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.com) from the maintainers to push
the changes.
works.
Further Comments
Summary by CodeRabbit
New Features
Tests
Style