Repository navigation
fix(transcoding): audio selection for direct files without native track support - #22
Merged
orochibraru merged 5 commits intoOct 5, 2026
Conversation
2 tasks done
Owner
|
Hey, I'm looking into this. |
Contributor
Author
|
Thanks! |
orochibraru
requested changes
Oct 4, 2026
orochibraru
left a comment
Owner
There was a problem hiding this comment.
Aside from a few comments, LGTM!
Thank you for submitting a PR.
Contributor
Author
|
I've pushed the updates based on your recommendations. The test import is now at the top of the file, and the audio fallback condition uses separate checks. Biome, type checks and all 918 unit tests passed locally. Thank you for reviewing my PR and welcoming my contribution to the project. I've been using it actively over the past week, and I'd love to contribute more. If I find any issues, I'll report them and work on PRs to fix them. |
orochibraru
approved these changes
Oct 5, 2026
orochibraru
pushed a commit
that referenced
this pull request
Oct 5, 2026
Merged
orochibraru
pushed a commit
that referenced
this pull request
Oct 5, 2026
orochibraru
pushed a commit
that referenced
this pull request
Oct 5, 2026
## [1.0.18](v1.0.17...v1.0.18) (2026-10-05) ### Features * fork e2e tests ([354d943](354d943)) * sveltekit3 stable (#21) ([810404e](810404e)) ### Bug Fixes * **transcoding:** audio selection for direct files without native track support (#22) ([2b589c1](2b589c1)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The startup probe skips the transmux pipeline when a direct MP4 or MKV file's default audio already plays. In browsers without
HTMLMediaElement.audioTracks, this leaves the player with no track list. The Audio menu stays hidden even when the file contains multiple playable audio tracks.Keep the existing transmux pipeline for these multi-track files when the browser lacks native track selection. The existing Audio menu can then switch tracks. Single-track files and browsers with native track selection keep their current playback path. HLS playback is unchanged.
This uses the existing codec and source-access checks. Files that the browser cannot read through CORS, or whose codecs the pipeline cannot handle, still cannot expose alternate tracks.
Type of change
Related issues
Fixes #23. The issue includes reproduction steps, a generated-media fixture and regression-test logs.
Validation
transmux-session.tsand passes with this fix. Issue fix: Audio menu missing for multi-track direct files without native track support #23 includes the failure output.bun run checkpassed with no errors. The service-worker check still reports the existing warning about having no Svelte input files.Screenshots
No screenshots attached. The playback check above verified both the menu selection and the resulting audio.
Checklist