Skip to content

test: cover embedded document validation #10814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amirdeljouyi wants to merge 1 commit into
base: develop
Choose a base branch
from
+52 −0
Open

test: cover embedded document validation #10814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions core/src/test/java/com/orientechnologies/orient/core/record/impl/ODocumentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import com.orientechnologies.orient.core.db.OrientDB;
import com.orientechnologies.orient.core.db.document.ODatabaseDocumentAbstract;
import com.orientechnologies.orient.core.db.record.ridbag.ORidBag;
import com.orientechnologies.orient.core.exception.OValidationException;
import com.orientechnologies.orient.core.id.ORecordId;
import com.orientechnologies.orient.core.metadata.schema.OClass;
import com.orientechnologies.orient.core.metadata.schema.OProperty;
Expand Down Expand Up @@ -93,6 +94,57 @@ public void testClearResetsFieldTypes() throws Exception {
assertEquals(doc.fieldType("binary"), null);
}

@Test
public void testValidateEmbeddedRejectsRecordIdValue() {
final String name = dbName + "_embeddedRid";
ODatabaseSession db = null;
OrientDB odb = null;
try {
odb = OCreateDatabaseUtil.createDatabase(name, "memory:", OCreateDatabaseUtil.TYPE_MEMORY);
db = odb.open(name, defaultDbAdminCredentials, OCreateDatabaseUtil.NEW_ADMIN_PASSWORD);

OClass clazz = db.getMetadata().getSchema().createClass("EmbeddedRidOwner");
OProperty property = clazz.createProperty("embedded", OType.EMBEDDED);

try {
ODocument.validateEmbedded(property, new ORecordId(1, 2));
org.junit.Assert.fail("Expected embedded RecordID value to be rejected");
} catch (OValidationException expected) {
assertTrue(expected.getMessage().contains("RecordID"));
}
} finally {
if (db != null) db.close();
if (odb != null) {
odb.drop(name);
odb.close();
}
}
}

@Test
public void testValidateEmbeddedAcceptsLinkedEmbeddedDocument() {
final String name = dbName + "_embeddedLinked";
ODatabaseSession db = null;
OrientDB odb = null;
try {
odb = OCreateDatabaseUtil.createDatabase(name, "memory:", OCreateDatabaseUtil.TYPE_MEMORY);
db = odb.open(name, defaultDbAdminCredentials, OCreateDatabaseUtil.NEW_ADMIN_PASSWORD);

OSchema schema = db.getMetadata().getSchema();
OClass embeddedClass = schema.createClass("EmbeddedLinkedValue");
OClass ownerClass = schema.createClass("EmbeddedLinkedOwner");
OProperty property = ownerClass.createProperty("embedded", OType.EMBEDDED, embeddedClass);

ODocument.validateEmbedded(property, new ODocument(embeddedClass));
} finally {
if (db != null) db.close();
if (odb != null) {
odb.drop(name);
odb.close();
}
}
}

@Test
public void testResetResetsFieldTypes() throws Exception {
ODocument doc = new ODocument();
Expand Down
Loading