Skip to content

fix: stop Heroku workflow from failing on every issue comment #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rainhead wants to merge 1 commit into from
Closed

fix: stop Heroku workflow from failing on every issue comment #1008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions .github/workflows/heroku.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,22 @@ name: Heroku

on:
deployment_status:
issue_comment:
types: [created, edited]

jobs:
deployment-status:
name: Check deployment status
runs-on: ubuntu-latest

# Continue only if some definitive status has been reported. Also allow
# manual refresh of status checks by commenting '/refresh-heroku-status'.
if: ${{ github.event.deployment_status.state != 'pending'
|| (contains(github.event.comment.body, '/refresh-heroku-status') && github.event.issue.pull_request) }}
# Continue only if some definitive status has been reported.
if: ${{ github.event.deployment_status.state != 'pending' }}

steps:
- uses: step-security/harden-runner@6c439dc8bdf85cadbbce9ed30d1c7b959517bc49 # v2.12.2
- uses: step-security/harden-runner@bf7454d06d71f1098171f2acdf0cd4708d7b5920 # v2.20.0
with:
egress-policy: audit

# Forward deployment's status to the deployed commit.
- uses: octokit/request-action@dad4362715b7fb2ddedf9772c8670824af564f0d # v2.4.0
- uses: octokit/request-action@b91aabaa861c777dcdb14e2387e30eddf04619ae # v3.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
Expand All @@ -38,27 +34,25 @@ jobs:
name: Check site health
runs-on: ubuntu-latest

# Run health check only if deployment succeeds. Also allow manual refresh
# of status checks by commenting '/refresh-heroku-status'.
if: ${{ github.event.deployment_status.state == 'success'
|| (contains(github.event.comment.body, '/refresh-heroku-status') && github.event.issue.pull_request) }}
# Run health check only if deployment succeeds.
if: ${{ github.event.deployment_status.state == 'success' }}

# Check that the deployed app returns successful HTTP response.
steps:
- uses: step-security/harden-runner@6c439dc8bdf85cadbbce9ed30d1c7b959517bc49 # v2.12.2
- uses: step-security/harden-runner@bf7454d06d71f1098171f2acdf0cd4708d7b5920 # v2.20.0
with:
egress-policy: audit

- id: health_check
uses: jtalk/url-health-check-action@b716ccb6645355dd9fcce8002ce460e5474f7f00 # v4
uses: jtalk/url-health-check-action@e7d5ebdc9027fbf494d2d034f3e8fc78f8b7a2b9 # v5
with:
url: ${{ github.event.deployment.payload.web_url }}
follow-redirect: true
max-attempts: 4
retry-delay: 30s
continue-on-error: true
# Set appropriate status to the deployed commit.
- uses: octokit/request-action@dad4362715b7fb2ddedf9772c8670824af564f0d # v2.4.0
- uses: octokit/request-action@b91aabaa861c777dcdb14e2387e30eddf04619ae # v3.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
Expand Down
Loading