Development - #22
Draft
ridswnt10 wants to merge 10 commits into
Draft
Conversation
…verification - Implemented `list_s3_files` to list all file keys under a specified prefix in S3. - Added `download_s3_object` for downloading files from S3 to a local path. - Created `verify_playlist` to check if the .ts files in a playlist match those in the S3 folder. - Integrated m3u8 for playlist handling and s3fs for S3 file operations.
…nd return lists directly for missing and extra files
- Enhanced logging capabilities by integrating the logging module for better traceability. - Implemented ThreadPoolExecutor for concurrent downloading of audio segments, improving performance. - Added a new method `get_all_clips` to facilitate batch processing of clips. - Introduced error handling for ffmpeg operations, including logging of bad files. - Created a backup of the original DateRangeHLSStream class for reference. - Added unit tests to cover edge cases for data availability and stream status.
- Added capabilities to the hls_utils - Fix moto v5.x compatibility (mock_s3 → mock_aws) - Resolve type errors and update deprecated APIs - Add comprehensive test suite (41/50 tests passing) - Add detailed function documentation - Improve error handling and code quality
for more information, see https://pre-commit.ci
ridswnt10
marked this pull request as ready for review
July 15, 2025 07:43
ridswnt10
marked this pull request as draft
July 15, 2025 07:44
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings major improvements to the
orca-hls-utilscodebase, including modernization, expanded test coverage, and significant refactoring for maintainability and reliability.Key Updates
Modernize codebase and add comprehensive test suite
mock_s3→mock_aws)Refactor DateRangeHLSStream for improved logging and parallel processing
Update s3_utils to include length in verify_playlist output
Update indexes for 1 year (2023-11 to 2024-11)
Update report metrics
Refactor code structure for improved readability and maintainability
Testing & Quality