Added ability to disable use of the terminal's default color palette.#34
Added ability to disable use of the terminal's default color palette.#34orbitalquark wants to merge 1 commit into
Conversation
8b6339c to
7862e78
Compare
1965a58 to
8a0e888
Compare
|
A positive consequence of Scinterm's new RGB color support - and this patch doesn't break it - is that the first 16 colors (predefined palette) are always left as they are. This means you don't have to care about restoring them on program termination, which was a headache previously when we could only use color ids 1-16. |
|
On the downside, there are 16-color terminals with the can_change_color capability (hello linux-16color). They can be used with custom RGB color schemes only when redefining color codes 0-15. Now, the patch can be adapted to touch 0-15 as well if there aren't enough COLORS - I already did this in my branch. But if you have to use color offsets, that necessarily restricts the number of colors you can redefine in your app and in Scinterm. For instance, Solarized on linux-16color will no longer be possible. This is probably an acceptable price to pay. |
7862e78 to
e218472
Compare
|
So I gather you approve of this feature? I can commit it as-is? (I just rebased to address a conflict.) |
Yes, I approve of it, but I made changes myself. Also, I am working on a new feature to support default terminal colors (color id -1 in Curses, see assume_default_colors()) and I wanted to submit both in one PR. Perhaps just wait for it. |
|
Okay, I'll wait to see what you came up with. |
No description provided.