Fix #6209: Add EDGE_TO_EDGE feature flag for edge-to-edge display support#6212
Draft
Neer-rn wants to merge 1 commit intooppia:developfrom
Draft
Fix #6209: Add EDGE_TO_EDGE feature flag for edge-to-edge display support#6212Neer-rn wants to merge 1 commit intooppia:developfrom
Neer-rn wants to merge 1 commit intooppia:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #6209: This PR adds the
EDGE_TO_EDGEfeature flag that will be used to gate all edge-to-edge display changes behind a toggle.On Android 15+ (API 35+), edge-to-edge is enforced by default and our app currently opts out using
windowOptOutEdgeToEdgeEnforcementinvalues-v35/themes.xml. This opt-out is deprecated in SDK 36 and will stop working -- link: https://developer.android.com/about/versions/16/behavior-changes-16#edge-to-edgeSo we need to properly handle window insets across all screens. This feature flag lets us gate those changes safely so we can roll back if something breaks.
Changes
EDGE_TO_EDGE = 19to theFeatureFlagIdproto enumfeature_flags.textprotowithdefault_is_enabled: false@EnableEdgeToEdgequalifier and default value inFeatureFlagConstants.ktFeatureFlagBindingModule.ktFeatureFlagsMapBindingModule.ktforceEnableEdgeToEdge()inTestPlatformParameterModule.ktfor testsFeatureFlagsLoggerTest.ktThe flag is
falseby default and will be set totrueonce all screens are fixed in #5940 and #6208.Full discussion and approach: #6196 and #5943
Essential Checklist