Skip to content

Fix part of #5663: Remove json lesson files#6143

Draft
harshsomankar123-tech wants to merge 8 commits intooppia:developfrom
harshsomankar123-tech:remove-json-lesson-files
Draft

Fix part of #5663: Remove json lesson files#6143
harshsomankar123-tech wants to merge 8 commits intooppia:developfrom
harshsomankar123-tech:remove-json-lesson-files

Conversation

@harshsomankar123-tech
Copy link
Copy Markdown
Contributor

Explanation

Fix part 02 of #5663:
This PR addresses the first half of issue #5663 by removing the JSON lesson loading path and transitioning the codebase entirely to the proto loading path (with the exception of questions). Specifically, this PR:

  • Deletes the LoadLessonProtosFromAssets qualifier and removes its providers from CachingModule and CachingTestModule, alongside corresponding BUILD.bazel updates.
  • Updates related domain classes (ExplorationRetrieverImpl, RevisionCardRetriever, ConceptCardRetriever, ClassroomController, TopicController, and TopicListController) by removing the constructor dependency for the flag, removing the JSON loading branches, deleting the unused *FromJson methods, and cleaning up unused org.json imports.
  • Keeps the JSON loading path specifically for QuestionRetriever, as proto question loading is not yet supported.
  • Removes the deprecated JSON lesson asset files from domain/src/main/assets/, keeping only questions.json.
  • Cleans up the test modules that provide LoadLessonProtosFromAssets and removes those providers to ensure a successful build.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

…on-files

# Conflicts:
#	domain/src/main/java/org/oppia/android/domain/topic/TopicController.kt
#	domain/src/main/java/org/oppia/android/domain/topic/TopicListController.kt
@harshsomankar123-tech
Copy link
Copy Markdown
Contributor Author

harshsomankar123-tech commented Mar 11, 2026

@BenHenning @adhiamboperes PTAL

Copy link
Copy Markdown
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot get merged until #6136 is first addressed. Please assign back once that's merged since it's it may affect CI.

@BenHenning
Copy link
Copy Markdown
Member

Also @harshsomankar123-tech it seems like there are unrelated changes in this PR unless I'm mistaken.

@oppiabot
Copy link
Copy Markdown

oppiabot bot commented Mar 26, 2026

Hi @harshsomankar123-tech, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 26, 2026
@harshsomankar123-tech harshsomankar123-tech marked this pull request as draft March 26, 2026 21:29
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Mar 26, 2026
@oppiabot
Copy link
Copy Markdown

oppiabot bot commented Apr 2, 2026

Hi @harshsomankar123-tech, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Apr 2, 2026
…on-files

# Conflicts:
#	domain/src/main/assets/test_exp_id_2.json
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Apr 3, 2026
@oppiabot
Copy link
Copy Markdown

oppiabot bot commented Apr 10, 2026

Hi @harshsomankar123-tech, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you! If you're unsure how to reassign this PR to a reviewer, please make sure to review the wiki page that details the Guidance on submitting PRs.

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Apr 10, 2026
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants