Fix part of #5663: Remove json lesson files#6143
Fix part of #5663: Remove json lesson files#6143harshsomankar123-tech wants to merge 8 commits intooppia:developfrom
Conversation
…on-files # Conflicts: # domain/src/main/java/org/oppia/android/domain/topic/TopicController.kt # domain/src/main/java/org/oppia/android/domain/topic/TopicListController.kt
BenHenning
left a comment
There was a problem hiding this comment.
This cannot get merged until #6136 is first addressed. Please assign back once that's merged since it's it may affect CI.
|
Also @harshsomankar123-tech it seems like there are unrelated changes in this PR unless I'm mistaken. |
|
Hi @harshsomankar123-tech, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
|
Hi @harshsomankar123-tech, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
…on-files # Conflicts: # domain/src/main/assets/test_exp_id_2.json
|
Hi @harshsomankar123-tech, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Explanation
Fix part 02 of #5663:
This PR addresses the first half of issue #5663 by removing the JSON lesson loading path and transitioning the codebase entirely to the proto loading path (with the exception of questions). Specifically, this PR:
LoadLessonProtosFromAssetsqualifier and removes its providers fromCachingModuleandCachingTestModule, alongside correspondingBUILD.bazelupdates.ExplorationRetrieverImpl,RevisionCardRetriever,ConceptCardRetriever,ClassroomController,TopicController, andTopicListController) by removing the constructor dependency for the flag, removing the JSON loading branches, deleting the unused*FromJsonmethods, and cleaning up unusedorg.jsonimports.QuestionRetriever, as proto question loading is not yet supported.domain/src/main/assets/, keeping onlyquestions.json.LoadLessonProtosFromAssetsand removes those providers to ensure a successful build.Essential Checklist