interfaces: handle missing DHCPv6 PD size - #10765
Open
jpawlowski wants to merge 1 commit into
Open
Conversation
Member
|
Isn’t PD size mandatory? |
Contributor
Author
|
I ended up with this setting when I was not finishing the initial setup wizard because the machine has only one network interface. so apparently one can end up in such situation. |
Member
|
Thanks. Need to check this. Historically the wizard does not cover IPv6 but it also should not delete settings. Not saying that it did, but better to check that. |
Contributor
Author
|
I should mention that I was also disabling IPv6 later because it had connection issues. I wasn't investigating those so far, maybe later. But maybe that's when this error was produced. I will start a new VM from scratch when there it time, also to help takle the IPv6 connectivity issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Use a null fallback when checking an optional DHCPv6 prefix delegation size.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Describe the problem
Tracked in #10764.
Describe the proposed solution
Apply a null fallback to both numeric prefix delegation checks. Existing numeric values remain unchanged, while an absent value follows the existing nonnumeric path.
Tested on OPNsense 26.7.2_2 with a DHCPv6 configuration lacking the PD-size field. IA-NA output was preserved, IA-PD remained omitted, and no PHP errors were added. PHP syntax validation also passed.
Related issue
Fixes #10764