Skip to content

interfaces: handle missing DHCPv6 PD size - #10765

Open
jpawlowski wants to merge 1 commit into
opnsense:masterfrom
jpawlowski:codex/handle-missing-dhcp6-pd-size
Open

interfaces: handle missing DHCPv6 PD size#10765
jpawlowski wants to merge 1 commit into
opnsense:masterfrom
jpawlowski:codex/handle-missing-dhcp6-pd-size

Conversation

@jpawlowski

Copy link
Copy Markdown
Contributor

TL;DR

Use a null fallback when checking an optional DHCPv6 prefix delegation size.

Important notices

Before you submit a pull request, we ask you kindly to acknowledge the following:

If AI was used, please disclose:

  • Model used: OpenAI Codex (GPT-5)
  • Extent of AI involvement: AI-assisted diagnosis, implementation, testing, and drafting; reviewed by the human contributor before submission.

Describe the problem

Tracked in #10764.


Describe the proposed solution

Apply a null fallback to both numeric prefix delegation checks. Existing numeric values remain unchanged, while an absent value follows the existing nonnumeric path.

Tested on OPNsense 26.7.2_2 with a DHCPv6 configuration lacking the PD-size field. IA-NA output was preserved, IA-PD remained omitted, and no PHP errors were added. PHP syntax validation also passed.


Related issue

Fixes #10764

@fichtner

Copy link
Copy Markdown
Member

Isn’t PD size mandatory?

@jpawlowski

Copy link
Copy Markdown
Contributor Author

I ended up with this setting when I was not finishing the initial setup wizard because the machine has only one network interface. so apparently one can end up in such situation.

@fichtner

Copy link
Copy Markdown
Member

Thanks. Need to check this. Historically the wizard does not cover IPv6 but it also should not delete settings. Not saying that it did, but better to check that.

@jpawlowski

Copy link
Copy Markdown
Contributor Author

I should mention that I was also disabling IPv6 later because it had connection issues. I wasn't investigating those so far, maybe later. But maybe that's when this error was produced. I will start a new VM from scratch when there it time, also to help takle the IPv6 connectivity issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

DHCPv6 configuration warns when prefix delegation size is absent

2 participants