use common book table component to show list of books#264
Open
use common book table component to show list of books#264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR refactors the book table component so it can be used to show the list of books both in the title detail and inbox views
Changes
isServerSideto determine whether it's a server side table or just normal data tableBookStatuscomponent to hide location when book is deleted/to be deleted when it's status text says the same thingBookStatusnow shows the locations alwaysDeletion DateformatCreated Atcolumn which contains link for visiting book and make rows clickable with hover and cursor pointer effect indicating the row can be clickedThis closes #241
This closes #236