coredns: fix netlink compat for wgsd plugin#29264
Merged
commodo merged 1 commit intoopenwrt:masterfrom Apr 29, 2026
Merged
Conversation
wgsd (WireGuard Service Discovery plugin) pulls in golang.zx2c4.com/wireguard/wgctrl -> mdlayher/genetlink v1.2.0 -> mdlayher/netlink v1.6.2. This version of netlink calls mdlayher/socket's Sendmsg/Recvmsg with the old API signatures (pre-context.Context, single-return-value Sendmsg), but coredns itself requires mdlayher/socket v0.5.1 which changed these signatures to include context.Context and return (int, error). Add a go get step that upgrades netlink to v1.7.2 after the wgsd plugin dependencies are pulled in, ensuring the build uses a netlink version compatible with socket v0.5.x. Should fix: https://downloads.openwrt.org/snapshots/faillogs/i386_pentium-mmx/packages/coredns/compile.txt ``` ../../../../../dl/go-mod-cache/github.com/mdlayher/netlink@v1.6.2/conn_linux.go:105:9: too many return values have (int, error) want (error) ../../../../../dl/go-mod-cache/github.com/mdlayher/netlink@v1.6.2/conn_linux.go:105:35: not enough arguments in call to c.s.Sendmsg have ([]byte, nil, *"golang.org/x/sys/unix".SockaddrNetlink, number) want (context.Context, []byte, []byte, "golang.org/x/sys/unix".Sockaddr, int) ../../../../../dl/go-mod-cache/github.com/mdlayher/netlink@v1.6.2/conn_linux.go:116:9: too many return values have (int, error) want (error) ../../../../../dl/go-mod-cache/github.com/mdlayher/netlink@v1.6.2/conn_linux.go:116:33: not enough arguments in call to c.s.Sendmsg have ([]byte, nil, *"golang.org/x/sys/unix".SockaddrNetlink, number) want (context.Context, []byte, []byte, "golang.org/x/sys/unix".Sockaddr, int) ../../../../../dl/go-mod-cache/github.com/mdlayher/netlink@v1.6.2/conn_linux.go:127:42: not enough arguments in call to c.s.Recvmsg have ([]byte, nil, number) want (context.Context, []byte, []byte, int) ../../../../../dl/go-mod-cache/github.com/mdlayher/netlink@v1.6.2/conn_linux.go:142:41: not enough arguments in call to c.s.Recvmsg have ([]byte, nil, number) want (context.Context, []byte, []byte, int) github.com/aws/aws-sdk-go-v2/aws/protocol/query github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding github.com/aws/smithy-go/private/requestcompression ``` Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
6441591 to
aa373d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @vooon
Description:
wgsd (WireGuard Service Discovery plugin) pulls in golang.zx2c4.com/wireguard/wgctrl -> mdlayher/genetlink v1.2.0 -> mdlayher/netlink v1.6.2. This version of netlink calls mdlayher/socket's Sendmsg/Recvmsg with the old API signatures (pre-context.Context, single-return-value Sendmsg), but coredns itself requires mdlayher/socket v0.5.1 which changed these signatures to include context.Context and return (int, error).
Add a go get step that upgrades netlink to v1.7.2 after the wgsd plugin dependencies are pulled in, ensuring the build uses a netlink version compatible with socket v0.5.x.
Should fix:
https://downloads.openwrt.org/snapshots/faillogs/i386_pentium-mmx/packages/coredns/compile.txt
🧪 Run Testing Details
✅ Formalities