ddns-scripts: improve updater help and legacy syntax error#29189
ddns-scripts: improve updater help and legacy syntax error#29189dhrm1k wants to merge 1 commit intoopenwrt:openwrt-24.10from
Conversation
d56c9b9 to
80a9057
Compare
feckert
left a comment
There was a problem hiding this comment.
That should be first merged to the master branch. After that we can backport this to the stable branches openwrt-24.10 and openwrt-25.12.
Please update the commit message with more context. Is the -N option always wrong? That’s never worked before? What about scripts that already use this option?
Additional make sure you do not exceed the character limit of 75 characters per line.
Use Fixes: <number> so the issue will be auto closed after merge.
Clarify why this change updates help/error text around the option name. The issue is not that -N is always wrong. The current parser behavior expects the lower-case form here, so showing -N in these messages is misleading and suggests a form that does not work in this code path. Also improve grammar in the multi-command error and add a focused hint for legacy '<section> <level>' usage so existing scripts are easier to adjust. This is message-level guidance only; no runtime parsing behavior changes. Fixes: openwrt#27737
80a9057 to
ac05f71
Compare
Thanks for the review. I updated the commit message with additional context:
I force-pushed these changes to this PR branch. |
|
Ideally, I’d like to have this in the master branch so I can backport it. |
|
Thanks for the clarification. I am preparing a master-specific version aligned with the procd-based flow. It only fixes incorrect I will open the master PR first and link it here for backport follow-up. Fixes: #27737 |
|
I opened a master-first PR which matches with procd handling: #29208 After this is merged, I will submit the stable backports. |
Fix updater help/error text around legacy invocation and option naming.
Ref: #27737
📦 Package Details
Maintainer: @feckert
Description:
This updates
dynamic_dns_updater.shmessaging only:-Nto-nin help/error textto much commandstotoo many commandsSECTION VERBOSEstyle is used (for exampleopc 0), pointing to-S <section> -v <level> -- startCC @feckert for review
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am