Skip to content

utils: add ipq-art-editor #29181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gvvsnrnaveen wants to merge 8 commits into
base: master
Choose a base branch
from
Open

utils: add ipq-art-editor #29181

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
584997b
utils: add ipq-art-editor
gvvsnrnaveen Apr 18, 2026
ff205ec
Adding URL in the package description
gvvsnrnaveen Apr 18, 2026
0dde053
Update utils/ipq-art-editor/Makefile
gvvsnrnaveen Apr 18, 2026
69e7a70
Update utils/ipq-art-editor/Makefile
gvvsnrnaveen Apr 18, 2026
2173145
Merge branch 'master' into ipq-art-editor
gvvsnrnaveen Apr 19, 2026
9b6db21
Adding PKG_JOBS variable and CFLAGS +=
gvvsnrnaveen Apr 19, 2026
cfd76e0
Merge branch 'master' into ipq-art-editor
gvvsnrnaveen Apr 20, 2026
018fae4
Merge branch 'master' into ipq-art-editor
gvvsnrnaveen Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions utils/ipq-art-editor/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
include $(TOPDIR)/rules.mk

PKG_NAME:=ipq-art-editor
PKG_VERSION:=1.0.1
PKG_RELEASE:=1

PKG_SOURCE:=$(PKG_VERSION).tar.gz
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using only the version as PKG_SOURCE risks filename collisions in the shared download cache (dl/) with other packages that may also use 1.0.1.tar.gz. Prefer a unique tarball name like ipq-art-editor-$(PKG_VERSION).tar.gz (and, if needed, set PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION) / rely on default PKG_BUILD_DIR) to keep downloads deterministic across the build system.

Suggested change
PKG_SOURCE:=$(PKG_VERSION).tar.gz
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member

@BKPepe BKPepe Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this was resolved, when Copilot is right?

PKG_SOURCE_URL:=https://github.com/gvvsnrnaveen/ipq-art-editor/archive/refs/tags/
PKG_HASH:=a6cb8191f9f06c7538c5ee7328c850a8ecd085573460e1afeae4e3b82f7b559e
PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)-$(PKG_VERSION)

PKG_LICENSE:=GPL-3.0-only
PKG_LICENSE_FILES:=LICENSE
PKG_MAINTAINER:=G. Naveen Kumar <naveenkumar.gvvsnr@gmail.com>

include $(INCLUDE_DIR)/package.mk

define Package/ipq-art-editor
SECTION:=utils
CATEGORY:=Utilities
TITLE:=IPQ ART partition editor utility
Comment thread
gvvsnrnaveen marked this conversation as resolved.
URL:=https://github.com/gvvsnrnaveen/ipq-art-editor
endef

define Package/ipq-art-editor/description
Utility to update MAC addresses, customer data, and raw bytes in
Qualcomm IPQ ART partitions/files and recalculate ART checksum.
Supports IPQ60xx and IPQ80xx platforms.
endef

TARGET_CFLAGS += -Wall -Wextra

define Build/Compile
$(MAKE) $(PKG_JOBS) -C $(PKG_BUILD_DIR)/src \
$(TARGET_CONFIGURE_OPTS) \
CFLAGS+=" $(TARGET_CFLAGS)" \
LDFLAGS="$(TARGET_LDFLAGS)"
endef

define Package/ipq-art-editor/install
$(INSTALL_DIR) $(1)/usr/sbin
$(INSTALL_BIN) $(PKG_BUILD_DIR)/src/ipq_art_editor $(1)/usr/sbin/ipq-art-editor
endef

$(eval $(call BuildPackage,ipq-art-editor))
Loading