Skip to content

util: work around broken device naming #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
efahl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

util: work around broken device naming #1593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion asu/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,12 +642,25 @@ def reload_profiles(app: FastAPI, version: str, target: str) -> bool:
settings.upstream_url + f"/{version_path}/targets/{target}/profiles.json"
)

app.profiles[version][target] = {
profiles = {
name.replace(",", "_"): profile
for profile, data in response.json()["profiles"].items()
for name in data.get("supported_devices", []) + [profile]
}

# Eliminate any remapping to alternate supported profiles. Must happen
# /after/ all of above to avoid order-of-listing problems. Also log an
# error message about the improperly defined profiles, as this indicates
# a bug in the Device definitions.
for profile in response.json()["profiles"]:
if profiles[profile] != profile:
# Here's what we should log, but we don't have a good "log once"
# mechanism yet, and don't want to flood the logs.
# f"ERROR: profile bug {version} {target} {profile} mapped to {profiles[profile]}"
profiles[profile] = profile

app.profiles[version][target] = profiles

return True


Expand Down
Loading