feat(sdk): DSPX-2754 add DynamicValueMapping service client wrapper#3635
feat(sdk): DSPX-2754 add DynamicValueMapping service client wrapper#3635alkalescent wants to merge 1 commit into
Conversation
|
Warning Review limit reached
More reviews will be available in 28 minutes and 48 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
comp:sdk
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the DynamicValueMapping service client wrapper to the SDK, enabling interaction with the newly added policy service. It includes the necessary dependency updates and integration steps to ensure the SDK can properly utilize the service, following the established pattern for Connect RPC wrappers. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. A new service client we bring, / To make the SDK sing. / With mappings dynamic, / The code is organic, / And policy is now quite the thing. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for the DynamicValueMappingServiceClient to the SDK. It updates the codegen configuration to include the new client, upgrades the github.com/opentdf/platform/protocol/go dependency to version 0.34.0, integrates the new client into the SDK struct, and introduces a wrapper implementation in sdk/sdkconnect/dynamicvaluemapping.go. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Add the sdkconnect wrapper for the DynamicValueMappingService and register it in the SDK, and bump protocol/go to v0.34.0 (which carries the dynamicvaluemapping package). This is the sdk step of the DSPX-2754 consumer split (protocol/go #3580 released first; service consumer PR #3568 depends on this sdk release). Signed-off-by: Krish Suchak <suchak.krish@gmail.com>
alkalescent
force-pushed
the
DSPX-2754-sdk-dynamic-value-mapping
branch
from
101a9d9 to
1da7b39
Compare
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
|
1 participant
Proposed Changes
sdkconnectclient wrapper for the newDynamicValueMappingServiceand register it on the SDK.protocol/goto v0.34.0 (released from feat(policy): DSPX-2754 DynamicValueMapping protos + generated code #3580), which carries thepolicy/dynamicvaluemappingpackage.This is the sdk step of the DSPX-2754 consumer split. Sequencing:
protocol/goprotos + generated code (feat(policy): DSPX-2754 DynamicValueMapping protos + generated code #3580) — merged, released as v0.34.0.sdkonce it is released.Checklist
Testing Instructions
cd sdk && GOWORK=off go build ./... && GOWORK=off GOFLAGS=-mod=mod go mod tidy(clean)make connect-wrapper-generateproduces no diffRelated