Skip to content

fix: manually sync OWNERS file until bug is fixed in autoowners #78834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
May 5, 2026
Merged

fix: manually sync OWNERS file until bug is fixed in autoowners #78834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 26 additions & 11 deletions ci-operator/config/openshift/osde2e/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,30 @@
# Logins who are not members of 'openshift' organization were filtered out
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md

approvers:
- christophermancini
- ritmun
- varunraokadaparthi
- yiqinzhang
options: {}
reviewers:
- christophermancini
- minlei98
- ritmun
- varunraokadaparthi
- yiqinzhang
- ritmun
- yiqinzhang
- varunraokadaparthi
- christophermancini
- minlei98
approvers:
- ritmun
- yiqinzhang
- varunraokadaparthi
- christophermancini

filters:
# Nightly job YAML files in openshift/release repo - ROSA engineers can approve
# Pattern: openshift-osde2e-main__nightly-*.yaml
# These files don't exist in osde2e repo, so this filter has no effect here
# Other files (openshift-osde2e-main.yaml, .config.prowgen, OWNERS) fall back to top-level approvers
Comment on lines +21 to +23
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Misleading comment — the filter DOES apply in this repo.

The comment on Line 22 states "this filter has no effect here", but "here" is ambiguous. The filter has no effect in the upstream osde2e source repo (because those YAML files don't exist there), but it does apply in this openshift/release repository where the matching openshift-osde2e-main__nightly-*.yaml files reside. The comment should clarify this distinction to avoid confusion.

✏️ Suggested clarification 
-  # Nightly job YAML files in openshift/release repo - ROSA engineers can approve
-  # Pattern: openshift-osde2e-main__nightly-*.yaml
-  # These files don't exist in osde2e repo, so this filter has no effect here
-  # Other files (openshift-osde2e-main.yaml, .config.prowgen, OWNERS) fall back to top-level approvers
+  # Nightly job YAML files exist only in openshift/release (not in the upstream osde2e repo),
+  # so autoowners cannot generate this filter automatically - it must be maintained manually.
+  # Pattern: openshift-osde2e-main__nightly-*.yaml
+  # ROSA engineers are granted approver rights for these paths.
+  # Other files (openshift-osde2e-main.yaml, .config.prowgen, OWNERS) fall back to top-level approvers.
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ci-operator/config/openshift/osde2e/OWNERS` around lines 21 - 23, Update the
misleading comment in the OWNERS file so it clarifies scope: change the line
that says "this filter has no effect here" to explicitly state that the filter
has no effect in the upstream osde2e source repo (because those YAMLs don't
exist there) but does apply in this repository (openshift/release) where files
matching openshift-osde2e-main__nightly-*.yaml exist; keep the surrounding
context about other files falling back to top-level approvers unchanged and
reference the pattern openshift-osde2e-main__nightly-*.yaml in the new wording.

"^openshift-osde2e-main__nightly-.*\\.yaml$":
approvers:
- bmeng
- dustman9000
- smarthall
- ravitri
- ritmun
- yiqinzhang
- varunraokadaparthi
- christophermancini