Skip to content

USHIFT-6978: install dracut-fips in RHEL 9 bootc FIPS images#6662

Closed
agullon wants to merge 3 commits into
openshift:release-4.22from
agullon:USHIFT-6978-4.22
Closed

USHIFT-6978: install dracut-fips in RHEL 9 bootc FIPS images#6662
agullon wants to merge 3 commits into
openshift:release-4.22from
agullon:USHIFT-6978-4.22

Conversation

@agullon
Copy link
Copy Markdown
Contributor

@agullon agullon commented May 13, 2026

Summary

  • Install dracut-fips in RHEL 9 bootc FIPS containerfiles (presubmit and release)
  • On RHEL 9, the fips dracut module is in the separate dracut-fips package — without it the initramfs lacks the module and the lsinitrd FIPS check fails
  • On RHEL 10+, this module was merged into the base dracut package and is always present
  • Cherry-pick of USHIFT-6978: remove initramfs FIPS module check from bootc validation #6657 to release-4.22 for CI testing

Test plan

  • Verify el98-lrel@ai-model-serving-online-fips scenario passes on RHEL 9 bootc
  • Verify FIPS test still passes on RHEL 10 bootc

Jira: https://issues.redhat.com/browse/USHIFT-6978

🤖 Generated with Claude Code

On RHEL 9, the fips dracut module is in the separate dracut-fips
package. Without it, the initramfs does not contain the fips module
and the lsinitrd FIPS validation check fails.

On RHEL 10+, this module was merged into the base dracut package and
is always present.

Add dracut-fips to both RHEL 9 FIPS containerfiles (presubmit and
release) so the FIPS test passes consistently across RHEL versions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

pre-commit.check-secrets: ENABLED
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 13, 2026

@agullon: This pull request references USHIFT-6978 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

  • Install dracut-fips in RHEL 9 bootc FIPS containerfiles (presubmit and release)
  • On RHEL 9, the fips dracut module is in the separate dracut-fips package — without it the initramfs lacks the module and the lsinitrd FIPS check fails
  • On RHEL 10+, this module was merged into the base dracut package and is always present
  • Cherry-pick of USHIFT-6978: remove initramfs FIPS module check from bootc validation #6657 to release-4.22 for CI testing

Test plan

  • Verify el98-lrel@ai-model-serving-online-fips scenario passes on RHEL 9 bootc
  • Verify FIPS test still passes on RHEL 10 bootc

Jira: https://issues.redhat.com/browse/USHIFT-6978

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 79d6a835-b810-41ad-80bf-009ba9aff832

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from copejon and kasturinarra May 13, 2026 07:36
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2026
@agullon agullon marked this pull request as draft May 13, 2026 07:36
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2026
@agullon
Copy link
Copy Markdown
Contributor Author

agullon commented May 13, 2026

/test e2e-aws-tests-bootc-release-el9

pre-commit.check-secrets: ENABLED
@agullon
Copy link
Copy Markdown
Contributor Author

agullon commented May 13, 2026

/test e2e-aws-tests-cache

@agullon
Copy link
Copy Markdown
Contributor Author

agullon commented May 13, 2026

/test e2e-aws-tests-bootc-release-el9

…fips package

On RHEL 9.8, dracut-fips was merged into the base dracut package,
making `dnf install dracut-fips` a no-op. The fips dracut module
files are present on disk but dracut is not configured to include
them in the initramfs, causing the lsinitrd FIPS validation to fail.

Replace the dracut-fips package install with an explicit dracut
config file that ensures the fips module is included in the initramfs
when bootc generates it during deployment.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

pre-commit.check-secrets: ENABLED
@agullon
Copy link
Copy Markdown
Contributor Author

agullon commented May 14, 2026

/test e2e-aws-tests-cache

@agullon
Copy link
Copy Markdown
Contributor Author

agullon commented May 14, 2026

/test e2e-aws-tests-bootc-release-el9

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

@agullon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-bootc-release-el9 2a8820d link true /test e2e-aws-tests-bootc-release-el9

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@agullon agullon closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants