Skip to content

OCPBUGS-79591: Prepare 1.3.4 release #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 3 commits into from
May 11, 2026
Merged

OCPBUGS-79591: Prepare 1.3.4 release #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d590eb
Konflux: Change name labels to match security labels
alebedev87 May 4, 2026
19876ec
hack: sync-version - sync release label
alebedev87 May 4, 2026
b7299f4
OCPBUGS-79591: Bump version label to 1.3.4
alebedev87 May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Containerfile.external-dns-operator
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ RUN make build-operator
FROM registry.access.redhat.com/ubi9/ubi-minimal:latest@sha256:7d4e47500f28ac3a2bff06c25eff9127ff21048538ae03ce240d57cf756acd00
LABEL maintainer="Red Hat, Inc."
LABEL com.redhat.component="external-dns-operator-container"
LABEL name="external-dns-operator"
LABEL version="1.3.3"
LABEL name="edo/external-dns-rhel9-operator"
LABEL version="1.3.4"
WORKDIR /
COPY --from=builder /workspace/bin/external-dns-operator /
# Red Hat certified container images have licenses.
Expand Down
6 changes: 3 additions & 3 deletions Containerfile.external-dns-operator-bundle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ LABEL com.redhat.delivery.operator.bundle: true
ARG FULL_COMMIT
ARG GIT_URL

LABEL name=external-dns-operator-bundle
LABEL version="1.3.3"
LABEL release="1.3.3"
LABEL name="edo/external-dns-operator-bundle"
LABEL version="1.3.4"
LABEL release="1.3.4"
LABEL maintainer='NetworkEdge team <aos-network-edge-staff@redhat.com>'
LABEL io.k8s.display-name='ExternalDNS Operator'
LABEL io.k8s.description='Operator bundle for the ExternalDNS Operator'
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.3.3
1.3.4
6 changes: 3 additions & 3 deletions bundle/manifests/external-dns-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,15 +338,15 @@ metadata:
features.operators.openshift.io/token-auth-aws: "false"
features.operators.openshift.io/token-auth-azure: "false"
features.operators.openshift.io/token-auth-gcp: "false"
olm.skipRange: <1.3.3
olm.skipRange: <1.3.4
operatorframework.io/suggested-namespace: external-dns-operator
operators.openshift.io/valid-subscription: '["OpenShift Kubernetes Engine", "OpenShift
Container Platform", "OpenShift Platform Plus"]'
operators.operatorframework.io/builder: operator-sdk-v1.16.0+git
operators.operatorframework.io/project_layout: go.kubebuilder.io/v3
repository: https://github.com/openshift/external-dns-operator
support: Red Hat, Inc.
name: external-dns-operator.v1.3.3
name: external-dns-operator.v1.3.4
Comment on lines +341 to +349
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "CSV version fields:"
rg -n 'name:\s*external-dns-operator\.v|olm\.skipRange:\s*<1\.3|^\s*version:\s*1\.3' \
  bundle/manifests/external-dns-operator.clusterserviceversion.yaml

echo
echo "Catalog references:"
rg -n 'external-dns-operator\.v1\.3\.[0-9]+|skipRange:\s*<1\.3\.[0-9]+' \
  catalog/v4.21/catalog.yaml catalog/v4.21/catalog-template.yaml

Repository: openshift/external-dns-operator

Length of output: 3990

Update catalog files to include v1.3.4 and maintain upgrade-chain consistency.

The CSV has been bumped to v1.3.4 with olm.skipRange: <1.3.4, but catalog/v4.21/catalog.yaml and catalog/v4.21/catalog-template.yaml still reference only up to v1.3.3. Add entries for v1.3.4 in both catalog files with replaces: external-dns-operator.v1.3.3 to ensure the upgrade path is available to users.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@bundle/manifests/external-dns-operator.clusterserviceversion.yaml` around
lines 341 - 349, The CSV was bumped to name: external-dns-operator.v1.3.4 and
olm.skipRange: <1.3.4 but the catalog entries were not updated; update both
catalog.yaml and catalog-template.yaml to add an entry for version
external-dns-operator.v1.3.4 and set replaces: external-dns-operator.v1.3.3 so
the upgrade chain is continuous, ensuring the new CSV name and olm.skipRange
remain as in the CSV.

Copy link
Copy Markdown
Contributor Author

@alebedev87 alebedev87 May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be done in follow up PRs.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alebedev87, understood! Would you like me to open a GitHub issue to track the catalog file updates (adding v1.3.4 entries with replaces: external-dns-operator.v1.3.3 in catalog/v4.21/catalog.yaml and catalog/v4.21/catalog-template.yaml) as a follow-up?

Copy link
Copy Markdown
Contributor Author

@alebedev87 alebedev87 May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, before the FBCs are updated we will need to get a bundle but this bundle will need the changes from this PR.

namespace: external-dns-operator
spec:
apiservicedefinitions: {}
Expand Down Expand Up @@ -627,7 +627,7 @@ spec:
minKubeVersion: 1.22.0
provider:
name: Red Hat, Inc.
version: 1.3.3
version: 1.3.4
webhookdefinitions:
- admissionReviewVersions:
- v1
Expand Down
1 change: 1 addition & 0 deletions hack/sync-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ for containerfile in "${containerfiles[@]}"; do
else
echo "[UPDATE] $(basename "$containerfile"): updating from $current_version to $version"
sed -i "s/version=\"[^\"]*\"/version=\"$version\"/" "$containerfile"
sed -i "s/release=\"[^\"]*\"/release=\"$version\"/" "$containerfile"
any_updated=true
fi
done
Expand Down