Skip to content

Replace ansible.module_utils.six imports with Python 3 stdlib and add… - #287

Open
chynasan wants to merge 1 commit into
openshift:stable-5from
chynasan:aca-6737/stable_5_compat
Open

Replace ansible.module_utils.six imports with Python 3 stdlib and add…#287
chynasan wants to merge 1 commit into
openshift:stable-5from
chynasan:aca-6737/stable_5_compat

Conversation

@chynasan

Copy link
Copy Markdown
Contributor

Backport of #286 to stable-5.

Since ansible-core 2.20 introduced a new pylint check (ansible-bad-import-from) that flags imports from ansible.module_utils.six, when a stdlib equivalent exists:

  • Replaced iteritems() with dict.items() in 3 files
  • Replace string_types with str in openshift_import_image.py
  • Add tests/sanity/ignore-2.20.txt for validate-modules errors
  • Add tests/sanity/ignore-2.21.txt for validate-modules errors

For issue #253

… sanity ignore files for ansible-core 2.20/2.21
@openshift-ci
openshift-ci Bot requested review from abikouo and jillr July 30, 2026 18:08
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 30, 2026
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown

Hi @chynasan. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2026
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abikouo, chynasan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abikouo abikouo added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2026
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2026
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

@chynasan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration 0cc4ccb link true /test integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants