Skip to content

[stable-4]: fix(ci): pin ansible-core below 2.19 in ansible-lint tox env - #282

Open
oraNod wants to merge 1 commit into
openshift:stable-4from
oraNod:fix/pin-ansible-stable-4
Open

[stable-4]: fix(ci): pin ansible-core below 2.19 in ansible-lint tox env#282
oraNod wants to merge 1 commit into
openshift:stable-4from
oraNod:fix/pin-ansible-stable-4

Conversation

@oraNod

@oraNod oraNod commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Fixes CI in #281 and #279

This change pins the ansible-core version becasue 2.19 removed ansible.parsing.yaml.constructor which ansible-lint imports directly, resulting in ModuleNotFoundError.

Verified the fix locally as well as by pushing this commit to #281

@openshift-ci
openshift-ci Bot requested review from abikouo and alinabuzachis July 28, 2026 10:48
@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oraNod
Once this PR has been reviewed and has the lgtm label, please assign alinabuzachis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 28, 2026
@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown

Hi @oraNod. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@oraNod oraNod changed the title fix(ci): pin ansible-core below 2.19 in ansible-lint tox env [stable-4]: fix(ci): pin ansible-core below 2.19 in ansible-lint tox env Jul 28, 2026
@abikouo abikouo added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2026
@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown

@oraNod: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration a2db4ec link true /test integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants