test: add unit tests for openshift_adm_prune_auth - #271
Conversation
* prepare release 5.0.0 (openshift#269) * prepare release 5.0.0 * update changelog to include inventory plugin removal * update changelog to include inventory plugin removal * update changlogs * update version to 6.0.0-dev0 * update version current to 5.0.0
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mouhaahmet The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @mouhaahmet. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
oraNod
left a comment
oraNod
left a comment
There was a problem hiding this comment.
Hi @mouhaahmet Can you please rebase your changes against the main branch?
I see a commit titled "Push 5.0.0 changes to main branch (#270)" and the author is @mandar242 It seems like the commit history somehow got mangled.
The PR description also refers to a fix for a potential KeyError but I don't see any changes to plugins/module_utils/openshift_adm_prune_auth.py.
The actual test changes here look pretty good to me though so thanks for that.
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| test_fixes: | |||
There was a problem hiding this comment.
test_fixes isn't a valid section. Please see
community.okd/changelogs/config.yaml
Line 12 in 74155f0
3 participants
I added unit tests for the openshift_adm_prune_auth module_utils.
Changes: