Skip to content

Add subscriptions page and fix PR preview - #77

Merged
AugustoL merged 3 commits into
openscan-explorer:devfrom
AugustoL:add-subscriptions-page
Dec 2, 2025
Merged

AugustoL merged 3 commits into
openscan-explorer:devfrom
AugustoL:add-subscriptions-page

Conversation

@AugustoL

@AugustoL AugustoL commented Dec 1, 2025 •

Copy link
Copy Markdown
Collaborator

This pull request introduces a new "Subscriptions" page to the application and updates the PR preview deployment workflow to improve reliability and separation of concerns. The main changes are grouped into frontend feature additions and workflow/deployment improvements:

Frontend Feature: Subscriptions Page

  • Added a new Subscriptions page, including a lazy-loaded component (LazySubscriptions) and a new route /subscriptions in App.tsx. The Navbar now includes a button to navigate directly to this page, with an appropriate icon for visual clarity. [1] [2] [3] [4] [5]
  • Introduced a new CSS class .button-secondary-inline for consistent styling of secondary inline buttons across the app.

Workflow and Deployment Improvements

  • Refactored the PR preview deployment process into two separate GitHub Actions workflows:
    • .github/workflows/deploy-pr-preview.yml now only builds the PR preview and uploads the build artifact and PR number as artifacts, removing deployment and PR comment logic. [1] [2]
    • Added a new .github/workflows/deploy-pr-preview-netlify.yml workflow that triggers on successful completion of the build workflow. This workflow downloads the artifacts, deploys the preview to Netlify, and comments on the PR with the preview URL.This pull request introduces a new "Subscriptions" page to the application, making it accessible via both the navigation bar and routing system. It also adds a new button style for secondary inline actions. The changes are grouped below by theme:

Feature: Subscriptions Page

  • Added a new lazily loaded Subscriptions page component and integrated it into the application's routing (src/components/LazyComponents.tsx, src/App.tsx). [1] [2] [3] [4]
  • Added a "Subscriptions" button to the navigation bar, allowing users to navigate directly to the new page (src/components/common/Navbar.tsx).

Styling

  • Introduced a new .button-secondary-inline CSS class for secondary inline buttons, including hover effects (src/styles/components.css).
  • Increased the font size of the .license-footer class from 0.9rem to 2rem for improved visibility (src/styles/components.css).

@AugustoL
AugustoL force-pushed the add-subscriptions-page branch from f890efd to 5cb57c0 Compare December 1, 2025 17:48
  Split the PR preview workflow into two separate workflows to handle
  fork PRs that don't have access to repository secrets:

  1. deploy-pr-preview.yml - Builds the PR and uploads artifacts
     (runs in fork context, no secrets needed)

  2. deploy-pr-preview-netlify.yml - Downloads artifacts and deploys
     (runs via workflow_run in base repo context with secrets access)

  This fixes: "Resource not accessible by integration" error
@AugustoL AugustoL changed the title Add subscriptions page Add subscriptions page and fix PR preview Dec 1, 2025
@AugustoL
AugustoL requested a review from MatiasOS December 1, 2025 17:56
@AugustoL
AugustoL merged commit 7d536d9 into openscan-explorer:dev Dec 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants