Conversation
1.8.0 ships ZcashClient and routes bip122 chain IDs by registry membership, so Bitcoin and Zcash IDs no longer collide on the shared prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
@openscan/network-connectorsfrom 1.7 to 1.8. Release 1.8.0 shipsZcashClient(the Zebra RPC surface), and it fixesbip122:routing so Bitcoin and Zcash chain IDs no longer collide on their shared CAIP-2 prefix.This is the first PR in the Zcash stack for #398; the following PRs build on it.
Related Issue
Closes #396
Type of Change
Changes Made
package.json:@openscan/network-connectorsgoes from1.7to1.8bun.lock: now resolves@openscan/network-connectors@1.8.0, with no other lockfile changesScreenshots (if applicable)
N/A
Checklist
npm run format:fixandnpm run lint:fixnpm run typecheckwith no errorsnpm run test:runAdditional Notes
Checked against the acceptance criteria in #396:
ClientFactory.createClientstill returnsBitcoinClientfor Bitcoin mainnet and testnet4, and returnsZcashClientfor both Zcash chain IDs.rpcConfig.tsanduseRpcLatencyTest.tsstill typecheck against the widenedrpcUrlstype;npm run typecheckis clean.npm run buildpasses.npm run test:runpasses (105 tests).Biome still reports one warning, which already exists on
dev: the unusedgetAlchemyBtcUrlinsrc/components/pages/settings/index.tsx.