Add scipts to monitor nginx ssl session ticket keys and session ticket r... - #7
Add scipts to monitor nginx ssl session ticket keys and session ticket r...#7lziest wants to merge 6 commits into
Conversation
|
change code style and file naming style. Make them consistent with existing ones. |
There was a problem hiding this comment.
Hmm, I still don't like this module name. given that all these functions are related to OpenSSL only (and not nginx at all), you should probably just name it openssl instead of nginx.openssl_ex_data. Thoughts?
|
@lziest Also, will you add some corresponding docs to the file |
941888d to
3eb5acd
Compare
|
Add docs, squashed minor changes and rebased. |
There was a problem hiding this comment.
Let's rename it to just openssl because this module has nothing to do with nginx.
|
Please |
There was a problem hiding this comment.
Please also add a line to set PATH environment, just like the docs for other tools. Thank you :)
72bb100 to
bba6a34
Compare
There was a problem hiding this comment.
Will you add some sample outputs?
There was a problem hiding this comment.
Also, please add sample outputs here in its docs and also some brief explanation if not too obvious.
|
@lziest Please add support for the |
There was a problem hiding this comment.
I think this tool should exit here as soon as it dumps the first key set. Thoughts?
|
I would like to squash the commits into one once it's ok to merge |
There was a problem hiding this comment.
Still no indentation in the output? It's hard to look ;)
There was a problem hiding this comment.
I've found these ratio descriptions a bit confusing. Maybe you can make it even clearer? How about these:
Ticket resumption attempts ratio in all SSL sessions: %d
Ticket resumption success ratio in all attempts: %d
Resumed ticket sessions in all SSL sessions: %d
2 participants
...esumptions.