Skip to content

Fix syncRotation ignored to AttachPlayerObjectToObject #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SimoSbara wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix syncRotation ignored to AttachPlayerObjectToObject #61

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4465f1
added syncRotation parameter to attachToObject() in IPlayerObject
SimoSbara Dec 20, 2025
4f7fc14
deleted junk
SimoSbara Dec 20, 2025
d5bbc56
restore order to IPlayerObject's methods (ABI)
SimoSbara Dec 22, 2025
84b2261
Add method with optional syncRotation
SimoSbara Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/Server/Components/Objects/objects.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,8 @@ struct IObject : public IBaseObject

struct IPlayerObject : public IBaseObject
{
virtual void attachToObject(IPlayerObject& object, Vector3 offset, Vector3 rotation) = 0;
/// Attach the object to another player object
virtual void attachToObject(IPlayerObject& object, Vector3 offset, Vector3 rotation, bool syncRotation) = 0;
Comment thread
SimoSbara marked this conversation as resolved.
Outdated

/// Attach the object to a player
virtual void attachToPlayer(IPlayer& player, Vector3 offset, Vector3 rotation) = 0;
Expand Down