sync: upstream moxygen 0aec257cdc25#266
Merged
Merged
Conversation
Summary: I'm allowing the `requestId` to not be set in the `Goaway`. Currently, the only caller of `MoQFrameWriter::writeGoaway` is `MoQFrameWriter::writeGoaway`, so this is a no-op, but it will come into use later on when we implement the sending of Goaways on request streams. ___ Differential Revision: D108016055 fbshipit-source-id: 0b20d761c5619c053f372c98c4b54552ed42fe1f
Summary: See title ___ Differential Revision: D108019594 fbshipit-source-id: c19df93bc90cae52d166e21102302d7ffa429cf8
Summary: GitHub commits: facebook/CacheLib@2ea12ae facebook/fb303@5ef2ba4 facebook/fbthrift@e49bd2c facebook/folly@836dffb facebook/hermes@7b429f6 facebook/mvfst@36f0ef4 facebook/proxygen@61b5387 facebook/pyrefly@f333275 facebook/wangle@47656df facebookexperimental/edencommon@635f590 facebookexperimental/rust-shed@266d690 facebookincubator/fizz@2703f67 meta-quest/vros-api@3d33dc5 react/yoga@f6206ec Reviewed By: bigfootjon fbshipit-source-id: 824a42fef12873a287cff7eb72b8933092694314
Reviewed By: franklinho Differential Revision: D107860314 fbshipit-source-id: 43c4ff5777411671d5453580510ecbea567cf929
gmarzot
approved these changes
Jun 11, 2026
gmarzot
left a comment
gmarzot
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approved by upstream sync workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated upstream sync.
0aec257cdc25The verify workflow will validate the standalone build. On success, this PR auto-merges.
Devs can push conflict-resolution commits to
sync/0aec257cdc25if needed.Created by
omoq-upstream-syncworkflow.This change is