Skip to content

transport: tighten picoquic guard to require imported target #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gmarzot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

transport: tighten picoquic guard to require imported target #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion moxygen/openmoq/transport/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
# For installed picoquic (e.g. getdeps); FetchContent builds define the target
# directly without going through find_package.
find_package(picoquic QUIET)
if(picoquic_FOUND OR TARGET picoquic::picoquic-core)
# Check for the imported target directly. picoquic_FOUND alone is not
# sufficient: upstream picoquic's cmake config (picoquic-config.cmake) sets
# picoquic_FOUND=TRUE but does not define the picoquic::picoquic-core target,
# so target_link_libraries below would fail at generate time.
if(TARGET picoquic::picoquic-core)
message(STATUS "picoquic found, building pico transport")
add_subdirectory(pico)
else()
Expand Down
Loading