Skip to content

Code Review Fix For Control Statements. #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SJBaroi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Code Review Fix For Control Statements. #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions presto-main/src/main/java/io/prestosql/operator/PartitionedOutputOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,8 +524,8 @@ public Object capture(BlockEncodingSerdeProvider serdeProvider)
{
PagePartitionerState myState = new PagePartitionerState();
// This was just flushed, so page builders must be empty
for (int i = 0; i < pageBuilders.length; i++) {
checkState(pageBuilders[i].isEmpty());
for (PageBuilder pageBuilder : pageBuilders) {
checkState(pageBuilder.isEmpty());
}
myState.rowsAdded = rowsAdded.get();
myState.pagesAdded = pagesAdded.get();
Expand Down
4 changes: 1 addition & 3 deletions presto-main/src/main/java/io/prestosql/sql/planner/LocalExecutionPlanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3134,9 +3134,7 @@ else if (context.getDriverInstanceCount().isPresent()) {

PipelineExecutionStrategy exchangeSourcePipelineExecutionStrategy = GROUPED_EXECUTION;
List<DriverFactoryParameters> driverFactoryParametersList = new ArrayList<>();
for (int i = 0; i < node.getSources().size(); i++) {
PlanNode sourceNode = node.getSources().get(i);

for (PlanNode sourceNode : node.getSources()) {
LocalExecutionPlanContext subContext = context.createSubContext();
PhysicalOperation source = sourceNode.accept(this, subContext);
driverFactoryParametersList.add(new DriverFactoryParameters(subContext, source));
Expand Down