Skip to content

Rephrase conditions to provide nonce in proof types based on presence of Nonce endpoint #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awoie wants to merge 11 commits into
base: main
Choose a base branch
from
+11 −10
Open

Rephrase conditions to provide nonce in proof types based on presence of Nonce endpoint #678

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
be34758
fix: rephrased conditions to provide nonce in proof types based on pr…
awoie Nov 11, 2025
e8d2ae4
ed: updated history
awoie Nov 11, 2025
7fb46cb
Applied Kristina's suggestion
awoie Nov 11, 2025
ee4b878
fix: improved nonce language
awoie Dec 7, 2025
15bc74f
fix: rephrased conditions for including nonce applied to 1.0
awoie Dec 7, 2025
1a0081f
Merge branch 'main' into awoie/fix-677
awoie Dec 7, 2025
949a6bc
Applied Gareth's suggestion
awoie Jan 27, 2026
7c87435
Applied Gareth's suggestion
awoie Jan 27, 2026
14e5f47
Making text consistent with other proof types
awoie Jan 27, 2026
1cd24ab
Making text consistent with other proof types
awoie Jan 27, 2026
e68347b
Merge branch 'main' into awoie/fix-677
Sakurann Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions 1.1/openid-4-verifiable-credential-issuance-1_1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3033,7 +3033,7 @@ The JWT MUST contain the following elements:
* `kid`: OPTIONAL. JOSE Header containing the key ID. If the Credential is to be bound to a DID, the `kid` refers to a DID URL which identifies a particular key in the DID Document that the Credential is to be bound to. It MUST NOT be present if `jwk` or `x5c` is present.
* `jwk`: OPTIONAL. JOSE Header containing the key material the new Credential is to be bound to. It MUST NOT be present if `kid` or `x5c` is present.
* `x5c`: OPTIONAL. JOSE Header containing at least one certificate where the first certificate contains the key that the Credential is to be bound to, additional certificates may also be present. It MUST NOT be present if `kid` or `jwk` is present.
* `key_attestation`: OPTIONAL. JOSE Header containing a key attestation as described in (#keyattestation). If the Credential Issuer provided a `c_nonce`, the `nonce` claim in the key attestation MUST be set to a server-provided `c_nonce`.
* `key_attestation`: OPTIONAL. JOSE Header containing a key attestation as described in (#keyattestation). If present, the `nonce` claim in the key attestation MUST be set to a server-provided `c_nonce`.
Comment thread
awoie marked this conversation as resolved.
Outdated
* `trust_chain`: OPTIONAL. JOSE Header containing an [@!OpenID.Federation] Trust Chain. This element MAY be used to convey key attestation, metadata, metadata policies, federation Trust Marks and any other information related to a specific federation, if available in the chain. When used for signature verification, the header parameter `kid` MUST be present.
Comment on lines 3206 to 3213

@mickrau mickrau Jul 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t like the use of JOSE Header in the parameter descriptions; the correct term would be JOSE Header parameter. However, that may be unnecessary, since the context already makes it clear that these are parameters of the JOSE Header. Nonetheless, we should state their concrete types explicitly—just as we do for the body.

For key_attestation, it is unclear whether the value must be encoded as a JSON string (JWT Compact Serialization) or whether it may also be provided as a JSON object (JWT JSON Serialization).


* in the JWT body,
Expand Down Expand Up @@ -3111,7 +3111,7 @@ When a W3C Verifiable Presentation as defined by [@VC_DATA_2.0] or [@VC_DATA] se
* `cryptosuite`: REQUIRED. If Credential Issuer metadata is provided, the value MUST match one of the entries in the `proof_signing_alg_values_supported` metadata parameter.
* `proofPurpose`: REQUIRED. MUST be set to `authentication`.
* `domain`: REQUIRED. MUST be set to the Credential Issuer Identifier.
* `challenge`: REQUIRED when the Credential Issuer has provided a `c_nonce`. It MUST NOT be used otherwise. String, where the value is a server-provided `c_nonce`. It MUST be present when the issuer has a Nonce Endpoint as defined in (#nonce-endpoint).
* `challenge`: REQUIRED when the Credential Issuer has a Nonce Endpoint as defined in (#nonce-endpoint). It MUST NOT be used otherwise. String, where the value is a server-provided `c_nonce`.
Comment thread
awoie marked this conversation as resolved.
Outdated
Comment thread
awoie marked this conversation as resolved.
Outdated

The Credential Issuer MUST validate that the W3C Verifiable Presentation used as a proof is actually signed with a key in the possession of the Holder.

Expand Down Expand Up @@ -3457,3 +3457,4 @@ The technology described in this specification was made available from contribut

* Initial draft created with same text as 1.0 Final
* Add back Interactive Authorization Endpoint text that was removed from the 1.0 draft
* Rephrase conditions to provide `nonce` in proof types based on presence of Nonce endpoint